Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version seems to break with Asterix soundtrack #25

Closed
VitorVilela7 opened this issue May 4, 2021 · 4 comments
Closed

Latest version seems to break with Asterix soundtrack #25

VitorVilela7 opened this issue May 4, 2021 · 4 comments
Assignees
@dgrfactory
Labels
bug Something isn't working fixed This issue was fixed, waiting for stable release

Comments

@VitorVilela7
Copy link

When you load any song from Asterix soundtrack, the note appears to be cut off as soon attack phrase is done. Envelope is cut to 00.

Probably, something is wrong on GAIN emulation.
@VitorVilela7
Copy link
Author

Version is v2.18.3

@dgrfactory dgrfactory self-assigned this May 4, 2021
@dgrfactory dgrfactory added the W.I.P Working in progress label May 4, 2021
@dgrfactory
Copy link
Owner

Hi, @VitorVilela7
Thank you for reporting the issue.

I have confirmed this reported issue, and released a fixed version.
https://github.com/dgrfactory/spcplay/releases/tag/2.18.4.7333

@dgrfactory dgrfactory added bug Something isn't working fixed This issue was fixed, waiting for stable release and removed W.I.P Working in progress labels May 4, 2021
@VitorVilela7
Copy link
Author

It is now working perfectly, thank you for the quick update!

@dgrfactory dgrfactory mentioned this issue Jun 4, 2021
Closed
@dgrfactory
Copy link
Owner

Released.
https://github.com/dgrfactory/spcplay/releases/tag/2.18.4.7379

dgrfactory added a commit that referenced this issue Jul 31, 2021
@dgrfactory
refs #25 Some sound does not output because catching up of KOFF immed…
8296e9c 
…iately after KON is too fast.
dgrfactory added a commit that referenced this issue Jul 31, 2021
@dgrfactory
refs #25 #29 Fix the check conditions of KOFF
2971348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrfactory dgrfactory

Labels
bug Something isn't working fixed This issue was fixed, waiting for stable release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VitorVilela7 @dgrfactory