Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting as .wav while in endless playback mode ignores ID666 length tags #56

Closed
Michpem opened this issue Feb 27, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working fixed This issue was fixed, waiting for stable release

Comments

@Michpem
Copy link

Michpem commented Feb 27, 2023

Hello! I found a little oddity while exporting .spc files as .wav while having the option for endless playback enabled. Basically, every time I use the .wav export function, I get an audio file that's exactly 2 minutes and 11 seconds (default time?), which doesn't happen when I enable the option for ID666 play time.

While this barely an issue, it's worth noting that the previous stable release seemed to use the ID666 tags to determine the length of the song before exporting it to .wav, even in endless playback mode.

@dgrfactory dgrfactory self-assigned this Feb 27, 2023
@dgrfactory dgrfactory added the bug Something isn't working label Feb 28, 2023
@dgrfactory
Copy link
Owner

Hi, @Michpem
Thank you for reporting the issue.

As you pointed out, the output time was unintentionally changed when wav output in endless mode.
This issue was fixed in the following release version.
https://github.com/dgrfactory/spcplay/releases/tag/2.19.6.7998

@dgrfactory dgrfactory added the fixed This issue was fixed, waiting for stable release label Mar 7, 2023
dgrfactory added a commit that referenced this issue Oct 15, 2023
* #56 エンドレスモードで WAVE 出力時、ID666 の時間が使用されない不具合修正
@dgrfactory
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue was fixed, waiting for stable release
Projects
None yet
Development

No branches or pull requests

2 participants