Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Immutant #13

Closed
tobias opened this issue Apr 9, 2015 · 4 comments
Closed

support Immutant #13

tobias opened this issue Apr 9, 2015 · 4 comments

Comments

@tobias
Copy link
Contributor

tobias commented Apr 9, 2015

Immutant 2.x has an async model that is similar to http-kit, so writing an adapter was straightforward. I have it sitting on a branch right now (https://github.com/tobias/spiral/tree/immutant-support), since it depends on changes that will be in the next release of Immutant (which should be this week). Once that's out, I'll update that branch and submit a PR (assuming you are interested in receiving it :) ). I also have a fix for route-concurrently that is needed for the tests to pass with Immutant (parked at tobias@9e23fde) that I'll also submit as a PR at the same time.

@dgrnbrg
Copy link
Owner

dgrnbrg commented Apr 9, 2015

Yes, I'm definitely interested in the PR! That fix looks good.

@tobias
Copy link
Contributor Author

tobias commented Apr 9, 2015

Great! I'll come back for a visit once we release.

tobias added a commit to tobias/spiral that referenced this issue Apr 14, 2015
tobias added a commit to tobias/spiral that referenced this issue Apr 16, 2015
tobias added a commit to tobias/spiral that referenced this issue Apr 16, 2015
The spiral version that works with Immutant is given as "0.?.0", since
such a release does not yet exist.
dgrnbrg added a commit that referenced this issue Apr 16, 2015
Add Immutant examples to README (#13)
@dgrnbrg
Copy link
Owner

dgrnbrg commented Apr 16, 2015

I think we now have solid support for Immutant. Thanks @tobias!

@dgrnbrg dgrnbrg closed this as completed Apr 16, 2015
@tobias
Copy link
Contributor Author

tobias commented Apr 16, 2015

My pleasure!

On Thu, Apr 16, 2015 at 3:56 PM, David Greenberg notifications@github.com
wrote:

Closed #13 #13.


Reply to this email directly or view it on GitHub
#13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants