Update rubocop-minitest requirement from = 0.17.2 to = 0.18.0 #596

dependabot · 2022-03-14T08:02:24Z

Updates the requirements on rubocop-minitest to permit the latest version.

Release notes

Sourced from rubocop-minitest's releases.

RuboCop Minitest 0.18.0

New features

#161: Add new Minitest/AssertPredicate and Minitest/RefutePredicate cops. (@koic)

Changes

#162: Make Minitest/AssertNil (Minitest/RefuteNil) aware of assert_predicate(obj, :nil?) (refute_predicate(obj, :nil?)). (@koic)

Changelog

Sourced from rubocop-minitest's changelog.

0.18.0 (2022-03-13)

New features

#161: Add new Minitest/AssertPredicate and Minitest/RefutePredicate cops. ([@koic][])

Changes

#162: Make Minitest/AssertNil (Minitest/RefuteNil) aware of assert_predicate(obj, :nil?) (refute_predicate(obj, :nil?)). ([@koic][])

0.17.2 (2022-02-12)

Bug fixes

#159: Fix a false positive for Minitest/UnreachableAssertion when using only one assertion method in assert_raises block. ([@koic][])

0.17.1 (2022-01-30)

Changes

#158: Make Minitest/UnreachableAssertion aware of assert and refute prefix methods. ([@koic][])

0.17.0 (2021-11-23)

New features

#155: Provide assert_offense, assert_correction, and assert_no_offenses testing APIs for custom Minitest cop development. ([@koic][])

0.16.0 (2021-11-14)

New features

#147: Add EnforcedStyle config parameter for Minitest/GlobalExpectations. ([@gi][])

Bug fixes

#142: Fix Minitest/GlobalExpectations autocorrect when receiver is lambda. ([@gi][])

#150: Fix a false positive for Minitest/AssertEmpty and RefuteEmpty cops when using empty method with any arguments. ([@koic][])

0.15.2 (2021-10-11)

Bug fixes

#145: Mark Minitest/AssertEmptyLiteral as safe auto-correction. ([@koic][])

0.15.1 (2021-09-26)

Bug fixes

#143: Fix an error for Minitest/LiteralAsActualArgumentTest when expected and actual arguments are literals. ([@koic][])

... (truncated)

Commits

67f9042 Cut 0.18.0
7520b9a Update Changelog
3f41b4c Merge pull request #161 from koic/add_new_minitest_assert_predicate_refute_pr...
b784f45 Tweak offense messages
8f25c50 Merge pull request #162 from koic/make_assert_nil_aware_of_assert_predicate
8bc4edb Make Minitest/AssertNil aware of assert_predicate
4c38d48 Add new Minitest/AssertPredicate and Minitest/RefutePredicate cops
f7694b5 Add yamllint GitHub workflow
54baa8b Switch back docs version to master
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dgroup · 2022-03-16T19:05:52Z

@rultor merge

rultor · 2022-03-16T19:06:59Z

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-03-16T19:11:30Z

@rultor merge

@dependabot[bot] @dgroup Oops, I failed. You can see the full log here (spent 4min)

  test_environment_provided                                      \u001b[32m PASS\u001b[0m (0.00s)
Lazylead::EnvironmentTest
  test_environment_absent                                        \u001b[32m PASS\u001b[0m (0.00s)
Lazylead::ExchangeTest
  test_exchange_email_notification_using_decrypted_credentials   \u001b[33m SKIP\u001b[0m (0.00s)
Lazylead::ExchangeTest
  test_email_notification_to_outlook_exchange                    \u001b[33m SKIP\u001b[0m (0.00s)
Lazylead::ExchangeTest
  test_exchange_email_with_attachment                            \u001b[33m SKIP\u001b[0m (0.00s)
  test_LL_database_structure_installed_successfully              \u001b[32m PASS\u001b[0m (3.98s)
  test_alert_in_case_duedate_changed_by_not_authorized_person    \u001b[32m PASS\u001b[0m (0.91s)
  test_construct_accuracy_from_orm                               \u001b[32m PASS\u001b[0m (6.43s)
  test_activesupport_is_activated_for_access_to_domain_entities  \u001b[32m PASS\u001b[0m (6.56s)
  test_scheduled_task_was_triggered_successfully                 \u001b[32m PASS\u001b[0m (7.27s)
  test_convert_column_to_json                                    \u001b[32m PASS\u001b[0m (6.52s)
  test_env_properties_injected                                   \u001b[32m PASS\u001b[0m (6.48s)
  test_task_properties_are_using_ENV_variables                   \u001b[32m PASS\u001b[0m (6.82s)
  test_task_properties_are_parsed_despite_on_wrong_config        \u001b[32m PASS\u001b[0m (7.00s)
  test_second_ticketing_system_is_found                          \u001b[32m PASS\u001b[0m (6.53s)
  test_postman_initiated_through_orm                             \u001b[32m PASS\u001b[0m (4.67s)

Finished in 10.94377s
217 tests, 426 assertions, \u001b[32m0 failures, 0 errors, \u001b[0m\u001b[33m16 skips\u001b[0m
Coverage report generated for Unit Tests, Unit Tests-0, Unit Tests-1, Unit Tests-10, Unit Tests-11, Unit Tests-2, Unit Tests-3, Unit Tests-4, Unit Tests-5, Unit Tests-6, Unit Tests-7, Unit Tests-8, Unit Tests-9 to /home/r/repo/coverage. 1421 / 1642 LOC (86.54%) covered.
Running RuboCop...
Inspecting 116 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[33mC\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[33mC\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[33mC\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[33mC\u001b[0m

Offenses:

\u001b[36mtest/lazylead/model_test.rb\u001b[0m:83:7: \u001b[33mC\u001b[0m: \u001b[33m[Correctable] \u001b[0mMinitest/RefutePredicate: Prefer using \u001b[33mrefute_predicate(ORM::Task.find(260), :to_h?)\u001b[0m. (https://minitest.rubystyle.guide/#refute-predicate)
      refute ORM::Task.find(260).to_h?
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
\u001b[36mtest/lazylead/system/jira_test.rb\u001b[0m:169:7: \u001b[33mC\u001b[0m: \u001b[33m[Correctable] \u001b[0mMinitest/AssertPredicate: Prefer using \u001b[33massert_predicate(NoAuthJira.new("https://jira.spring.io")
                       .issues("key=DATAJDBC-480")
                       .first["absent field"], :blank?)\u001b[0m. (https://minitest.rubystyle.guide/#assert-predicate)
      assert NoAuthJira.new("https://jira.spring.io") \u001b[33m...\u001b[0m
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
\u001b[36mtest/lazylead/task/accuracy/onlyll_test.rb\u001b[0m:39:7: \u001b[33mC\u001b[0m: \u001b[33m[Correctable] \u001b[0mMinitest/AssertPredicate: Prefer using \u001b[33massert_predicate(Labels.new(
        NoAuthJira.new("https://jira.spring.io").issues("key=XD-3725").first,
        Opts.new("grid" => "PullRequest,  ,")
      ), :exists?)\u001b[0m. (https://minitest.rubystyle.guide/#assert-predicate)
      assert Labels.new( \u001b[33m...\u001b[0m
      ^^^^^^^^^^^^^^^^^^
\u001b[36mtest/lazylead/task/accuracy/onlyll_test.rb\u001b[0m:46:7: \u001b[33mC\u001b[0m: \u001b[33m[Correctable] \u001b[0mMinitest/AssertPredicate: Prefer using \u001b[33massert_predicate(Labels.new(
        NoAuthJira.new("https://jira.spring.io")
                  .issues("key=XD-3725", expand: "changelog")
                  .first,
        Opts.new("grid" => "PullRequest", "author" => "grussell")
      ), :valid?)\u001b[0m. (https://minitest.rubystyle.guide/#assert-predicate)
      assert Labels.new( \u001b[33m...\u001b[0m
      ^^^^^^^^^^^^^^^^^^
\u001b[36mtest/test.rb\u001b[0m:202:7: \u001b[33mC\u001b[0m: \u001b[33m[Correctable] \u001b[0mMinitest/AssertPredicate: Prefer using \u001b[33massert_predicate(text, :blank?, "Text isn't blank")\u001b[0m. (https://minitest.rubystyle.guide/#assert-predicate)
      assert text.blank?, "Text isn't blank"
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

116 files inspected, \u001b[31m5 offenses\u001b[0m detected, \u001b[33m5 offenses\u001b[0m auto-correctable
RuboCop failed!
container bf351764fbacdcde7a2bab1b00c6c8bb45fce7d3b3fe1a9bf2322c3d3ec70a3b is dead
Wed Mar 16 20:11:22 CET 2022

Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.17.2...v0.18.0) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

sonarcloud · 2022-03-27T16:42:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

dependabot bot added the dependencies Pull requests that update a dependency file label Mar 14, 2022

dependabot bot force-pushed the dependabot/bundler/rubocop-minitest-eq-0.18.0 branch 2 times, most recently from ce07c0b to 47309b5 Compare March 27, 2022 16:41

dependabot bot force-pushed the dependabot/bundler/rubocop-minitest-eq-0.18.0 branch from 47309b5 to 3ccfb84 Compare March 27, 2022 16:42

dgroup merged commit 7903703 into master Mar 27, 2022

delete-merged-branch bot deleted the dependabot/bundler/rubocop-minitest-eq-0.18.0 branch March 27, 2022 16:43

dgroup added this to the 0.13.0 milestone Mar 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop-minitest requirement from = 0.17.2 to = 0.18.0 #596

Update rubocop-minitest requirement from = 0.17.2 to = 0.18.0 #596

dependabot bot commented on behalf of github Mar 14, 2022 •

edited

dgroup commented Mar 16, 2022

rultor commented Mar 16, 2022

rultor commented Mar 16, 2022

sonarcloud bot commented Mar 27, 2022

Update rubocop-minitest requirement from = 0.17.2 to = 0.18.0 #596

Update rubocop-minitest requirement from = 0.17.2 to = 0.18.0 #596

Conversation

dependabot bot commented on behalf of github Mar 14, 2022 • edited

RuboCop Minitest 0.18.0

New features

Changes

0.18.0 (2022-03-13)

New features

Changes

0.17.2 (2022-02-12)

Bug fixes

0.17.1 (2022-01-30)

Changes

0.17.0 (2021-11-23)

New features

0.16.0 (2021-11-14)

New features

Bug fixes

0.15.2 (2021-10-11)

Bug fixes

0.15.1 (2021-09-26)

Bug fixes

dgroup commented Mar 16, 2022

rultor commented Mar 16, 2022

rultor commented Mar 16, 2022

sonarcloud bot commented Mar 27, 2022

dependabot bot commented on behalf of github Mar 14, 2022 •

edited