Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to enable the user define the grid plane size/amount. #63

Merged
merged 1 commit into from Apr 9, 2014
Merged

Added option to enable the user define the grid plane size/amount. #63

merged 1 commit into from Apr 9, 2014

Conversation

Micheus
Copy link
Collaborator

@Micheus Micheus commented Jan 14, 2014

NOTE: It was add a new option to the Preferences dialog where the user can define the grid size/amount. [Micheus]
The range is 10 (current) to 200 and the camera distance (for reset camera operation) is calculated to 80% of this size (like the current too).

@dgud
Copy link
Owner

dgud commented Apr 3, 2014

Do not like that you move the camera away.
If I create the largest grid, then close wings and restart I start way out when I create a cube.
What do you think?

@Micheus
Copy link
Collaborator Author

Micheus commented Apr 3, 2014

The way I changed the camera location was to preserve the current proportions. Currently, the grid size is 10 and the camera location is 8 units far from the centre. If the user needs a large grid I was assuming he will model something big. In this case, by using reset [R] with the current settings the camera would always be placed too close (or inside) of the object. Also, I think that the use will not change it all the time - he will find a comfortable size.

But, if you think that was not a good approach, I cant put it back to the fixed distance (?CAMERA_DIST).

@dgud
Copy link
Owner

dgud commented Apr 3, 2014

I know what you did, I have looked at the code.

I thought re-starting wings brought me to far away, the new cube was very small
which means I'll have to start by zooming in, since it's a preference and not a scene property.

Either change it back or decrease the amount maybe to 25-50% with a minimum distance of 8?
But I don't know, do something clever :-)

@Micheus
Copy link
Collaborator Author

Micheus commented Apr 3, 2014

...and if we add this option to the Preferences too? weird?!
The current grid size option is a range of 10-200. Maybe we would leave the user free to set the default camera distance in the same way: 8-100 ?

@dgud
Copy link
Owner

dgud commented Apr 3, 2014

I don't really like to many options :-)
It should be easy to use and configure, it's easy to add options for
everything it is much harder
to do something good and intelligent.

But if the camera is saved (in your other pull req) maybe we should keep
the default camera pos as it is?

On Thu, Apr 3, 2014 at 11:17 PM, Micheus Vieira notifications@github.comwrote:

...and if we add this option to the Preferences too? weird?!
The current grid size option is a range of 10-200. Maybe we would leave
the user free to set the default camera distance in the same way: 8-100 ?

Reply to this email directly or view it on GitHubhttps://github.com//pull/63#issuecomment-39506090
.

@Micheus
Copy link
Collaborator Author

Micheus commented Apr 3, 2014

Ok, I think we can use your suggestion about "25-50% with a minimum distance of 8": 50%

The other pull req is useful for when we leave the project and reload it in another moment. Our problem here is related to the use of the command Reset [R] that will place the camera in the default position (in a distance that we are try to find the best way to define it).

So, we have a deal with 50%. 😄

@dgud
Copy link
Owner

dgud commented Apr 3, 2014

In the end grid size should be infinity and adjust itself to near and far
distances :-)

On Thu, Apr 3, 2014 at 11:33 PM, Micheus Vieira notifications@github.comwrote:

Ok, I think we can use your suggestion about "25-50% with a minimum
distance of 8": 50%

The other pull req is useful for when we leave the project and reload it
in another moment. Our problem here is related to the use of the command
Reset [R] that will place the camera in the default position (in a distance
that we are try to find the best way to define it).

So, we have a deal with 50%. [image: 😄]

Reply to this email directly or view it on GitHubhttps://github.com//pull/63#issuecomment-39507721
.

@Micheus
Copy link
Collaborator Author

Micheus commented Apr 3, 2014

Right. So, I'm going to set the range to 10-Infinity and calculate the default camera location to 50% of that size.

Have no limit with the grid and distance would help with this kind of project: https://fbcdn-sphotos-g-a.akamaihd.net/hphotos-ak-ash3/t1.0-9/1017482_468002263303855_1626436628_n.jpg

@dgud
Copy link
Owner

dgud commented Apr 4, 2014

No is should be done automagicly, but we do that later, keep max at 200 or maybe up to 400.

@Micheus
Copy link
Collaborator Author

Micheus commented Apr 4, 2014

Oh, I see now. Much better.

Many users have asked for an option for customize the grid size. So, now users can define the grid size in the Preferences dialog (General->Grid).
The camera distance is set to 50% of the grid size with a minimum value of 8 wings3d units.

NOTE: Added option to customize the grid size.
@Micheus
Copy link
Collaborator Author

Micheus commented Apr 4, 2014

Dan, I just implemented the auto adjust option - what a good idea. It's simplest them this one. I'll make a new branch and a new pull request. I would like you not close this one until you check and approve the new one.

You can see it working in this video: http://youtu.be/ezjyPkcfcns

Thanks

@dgud dgud merged commit bed6daa into dgud:master Apr 9, 2014
@Micheus Micheus deleted the mv/grid_size branch April 12, 2014 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants