Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It was added the possibility the user define more then diffuse color to default material. #67

Closed
wants to merge 2 commits into from
Closed

Conversation

Micheus
Copy link
Collaborator

@Micheus Micheus commented Mar 9, 2014

NOTE:

  • User now can define all OpenGL settings for "default" material.
    In the Material Editor dialog - after the user change those fields - a new button "Save" enable the user save them in the preferences. A button "Restore" enable the user to reset the default material to that usual Wings3d one that is hard coded.
  • It was also changed a little the way how Wings3d read/import the "default" material from an existent file. If the only difference between both default materials is the OpenGL parameter, then the material being read is replaced by the current one, otherwise it create a new variation of that material name as already has been done. Thanks to MikeJ and oort for the suggestions and tests. [Micheus]

…fault material. In the Material Editor dialog the user can change those fields and use a new button Save for save in the preferences the new material properties. Other button - Restore - enable the user to reset to Wings3d default material properties that is hard coded.

These new informations are mantained by a new preferences variable preserving the compatibility previous preference file.

Also, it was changed a little the way how Wings3d read/import the default material from an existent file. If the only difference between both default materials is the OpenGL parameter, then the material being read is replaced by the current one, otherwise it create a new variation of that material name as already has been done. Thanks to MikeJ and oort for the suggestions and tests. [Micheus]
@Micheus
Copy link
Collaborator Author

Micheus commented Mar 9, 2014

Dan, just in case interest you we (MikeJ, oort and me) had talked about this subject at the forum from this post and on: http://www.wings3d.com/forum/showthread.php?tid=118&pid=4129#pid4129

@dgud
Copy link
Owner

dgud commented Mar 22, 2014

I do not like it at all default material should be a diffuse white-greyish,
as it it today it changes with the
theme as well?

On Sun, Mar 9, 2014 at 9:29 PM, Micheus Vieira notifications@github.comwrote:

Dan, just in case interest you we (MikeJ, oort and me) had talked about
this subject at the forum from this post and on:
http://www.wings3d.com/forum/showthread.php?tid=118&pid=4129#pid4129

Reply to this email directly or view it on GitHubhttps://github.com//pull/67#issuecomment-37137931
.

@Micheus
Copy link
Collaborator Author

Micheus commented Mar 22, 2014

If I understood you right, yes, each theme has a different default colour:

  • Classic Green -> white-greyish;
  • Olive -> "light" green-greyish;
  • Grey Blue -> "light" blue-greyish;
  • Dark Blue -> something like a skin colour.

By open an old project after the theme be change will create a new default material (like default1, default2,...) that I think is not right and was fixed too.

About the changes: it adds a new structure into Preferences.txt. It do not overwrite the default colour setting in the Preference dialog - that information is used to enable the user to reset the default material to its default values (based in the theme).

I just made possible a user change that if he/her wants do that for some reason. As you can notice in that thread.

I can record a video if you want see it working.

@dgud
Copy link
Owner

dgud commented Mar 23, 2014

I don't like the change of default color at all, if the user want a another
color he can add a another material.

On Sun, Mar 23, 2014 at 12:44 AM, Micheus Vieira
notifications@github.comwrote:

If I understood you right, yes, each theme has a different _default_colour:

  • Classic Green -> white-greyish;
  • Olive -> "light" green-greyish;
  • Grey Blue -> "light" blue-greyish;
  • Dark Blue -> something like a skin colour.

By open an old project after the theme be change will create a new default
material (like default1, default2,...) that I think is not right and
was fixed too.

About the changes: it adds a new structure into Preferences.txt. It do
not overwrite the default colour setting in the Preference dialog -
that information is used to enable the user to reset the _default_material to its default values (based in the theme).

I just made possible a user change that if he/her wants do that for some
reason. As you can notice in that thread.

I can record a video if you want see it working.

Reply to this email directly or view it on GitHubhttps://github.com//pull/67#issuecomment-38367874
.

@dgud dgud closed this Apr 2, 2014
@Micheus Micheus deleted the mv/default_material branch September 23, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants