Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected passes of some binary-decode tests #1082

Closed
sjakobi opened this issue Jul 6, 2019 · 1 comment · Fixed by #1088
Closed

Unexpected passes of some binary-decode tests #1082

sjakobi opened this issue Jul 6, 2019 · 1 comment · Fixed by #1088

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented Jul 6, 2019

When adding some tests in #1072 I discovered that some expected failures actually pass:

tests/binary-decode/failure/unit/ApplyNoArgs
tests/binary-decode/failure/unit/LambdaExplicitlyNamedUnderscore
tests/binary-decode/failure/unit/NaturalNegativeOne
tests/binary-decode/failure/unit/PiExplicitlyNamedUnderscore
tests/binary-decode/failure/unit/VariableExplicitlyNamedUnderscore

It would be good if someone with experience with the binary code could take a look.
Gabriella439 added a commit that referenced this issue Jul 7, 2019
@Gabriella439
Fix unexpected decoding successes in tests
b44535a 
Fixes #1082

All of the successes are due to accepting expressions that would not
have been produced by a compliant encoder, such as:

* Expressions that use a variable name of `_` that could have been
  encoded more compactly

* An expression tagged as a `Natural` number storing a negative number

* An expression encoding a function appled to 0 arguments
@Gabriella439 Gabriella439 mentioned this issue Jul 7, 2019
Merged
@Gabriella439
Copy link
Collaborator

Fix is up here: #1088

@mergify mergify bot closed this as completed in #1088 Jul 7, 2019
mergify bot pushed a commit that referenced this issue Jul 7, 2019
@Gabriella439 @mergify
Fix unexpected decoding successes in tests (#1088)
635a448 
Fixes #1082

All of the successes are due to accepting expressions that would not
have been produced by a compliant encoder, such as:

* Expressions that use a variable name of `_` that could have been
  encoded more compactly

* An expression tagged as a `Natural` number storing a negative number

* An expression encoding a function appled to 0 arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unexpected decoding successes in tests dhall-lang/dhall-haskell
2 participants
@Gabriella439 @sjakobi