Add dhall-json support for unions as keys
#1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inspired by this StackOverflow question: https://stackoverflow.com/questions/56967374/dynamic-records-key-type
sjakobi
reviewed
Jul 12, 2019
There was a problem hiding this comment.
Looks useful!
Is this at an experimental stage right now? At some point, docs would be nice.
Regarding the tests: I feel like they would be easier to follow and possibly more robust if they were implemented with actual dhall and json files. But that's just nitpicking!
... as suggested by @sjakobi
|
@sjakobi: I added documentation, but I'm going to split out the test-related changes into a separate pull request |
Gabriella439
added a commit
that referenced
this pull request
Jul 13, 2019
... as suggested @sjakobi in #1094 (review)
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2019
* Move more `dhall-json` test logic into data files ... as suggested @sjakobi in #1094 (review) * Fix CI failure ... as caught by @sjakobi * Fix missing import of `(<>)` ... as noted by @sjakobi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by this StackOverflow question:
https://stackoverflow.com/questions/56967374/dynamic-records-key-type