dhall-lsp-server: Turn imports into clickable links #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2019 16:06
Also modifies `localToPath` to return a relative path if the input was relative, rather than resolving relative paths by appending the current directory.
This implements a handler for 'Document Link' requests. As a result, imports are now clickable!
EggBaconAndSpam
commented
Jul 16, 2019
|
|
||
| Here -> do | ||
| Directory.getCurrentDirectory | ||
| return "." | ||
|
|
There was a problem hiding this comment.
What was the rationale behind having localToPath return absolute paths in the first place?
There was a problem hiding this comment.
Never mind, I simply changed exprFromUncachedImport to call makeAbsolute on the resulting path, thus recovering the original behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that remote imports were already clickable since they were recognised by VSCode as urls.