Check normalizeWithM for consistency with normalize #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implements constant folding of Natural/fold applications normalizeWithM.
* Changes the Arbitrary Var instance to generate only non-negative indices.
Otherwise failures like this one would pop up:
normalizeWithM should be consistent with normalize: FAIL (8.51s)
*** Failed! Falsified (after 318133 tests and 6 shrinks):
Let (Binding {variable = "", annotation = Nothing, value = List} :| []) (Var (V "" (-1)))
Var (V "" (-1)) /= Var (V "" (-2))
Use --quickcheck-replay=180244 to reproduce.
Fixes #1114.
|
Sadly I couldn't quite figure out the root cause of the discrepancy in the let-shifting. |
sjakobi
commented
Jul 18, 2019
| normalizeWithMIsConsistentWithNormalize expression = | ||
| case Control.Spoon.spoon (Dhall.Core.normalize expression :: Expr () Import) of | ||
| Just nf -> | ||
| let nfM = runIdentity (Dhall.Core.normalizeWithM (\_ -> Identity Nothing) expression) |
There was a problem hiding this comment.
Would it be a good idea to export this "trivial" normalizer as an example?
Something like
boringNormalizer :: Normalizer a
boringNormalizer _ = Identity Nothing
Not sure about the name…
There was a problem hiding this comment.
Probably not. I doubt anybody would use it
Previously it could produce about any number, not just non-negative ones.
Gabriella439
approved these changes
Jul 19, 2019
| normalizeWithMIsConsistentWithNormalize expression = | ||
| case Control.Spoon.spoon (Dhall.Core.normalize expression :: Expr () Import) of | ||
| Just nf -> | ||
| let nfM = runIdentity (Dhall.Core.normalizeWithM (\_ -> Identity Nothing) expression) |
There was a problem hiding this comment.
Probably not. I doubt anybody would use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements constant folding of Natural/fold applications normalizeWithM.
Changes the Arbitrary Var instance to generate only non-negative indices.
Otherwise failures like this one would pop up:
Fixes #1114.