Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NaN to be judgmentally equivalent to itself #1231

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Fix NaN to be judgmentally equivalent to itself #1231

merged 2 commits into from
Aug 9, 2019

Conversation

Gabriella439
Copy link
Collaborator

... as required by the standard

Fixes #1224

@Gabriella439
Fix NaN to be judgmentally equivalent to itself
36f9729 
... as required by the standard

Fixes #1224
@Gabriella439 Gabriella439 mentioned this pull request Aug 9, 2019
Closed
sjakobi
sjakobi approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine more efficient solutions but I don't believe that it currently matters. 👍

@mergify mergify bot merged commit c392f4a into master Aug 9, 2019
@mergify mergify bot deleted the gabriel/1224 branch August 9, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(assert : NaN === NaN) fails
2 participants
@Gabriella439 @sjakobi