Fix Inject instance for lists
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1254 This also adds tests for conversions back and forth between Dhall and Haskell values
sjakobi
reviewed
Aug 29, 2019
dhall/tests/Dhall/Test/Dhall.hs
Outdated
| , "2" `correspondsTo` (2 :: Natural) | ||
| , "+2" `correspondsTo` (2 :: Integer) | ||
| , "2.0" `correspondsTo` (2.0 :: Double) | ||
| -- , "2.0" `correspondsTo` (2.0 :: Scientific) |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
Missing instance, which I can add for symmetry
There was a problem hiding this comment.
Can you add a comment regarding the missing instance?
dhall/tests/Dhall/Test/Dhall.hs
Outdated
| -- , "2.0" `correspondsTo` (2.0 :: Scientific) | ||
| , "\"ABC\"" `correspondsTo` ("ABC" :: Data.Text.Text) | ||
| , "\"ABC\"" `correspondsTo` ("ABC" :: Data.Text.Lazy.Text) | ||
| -- , "\"ABC\"" `correspondsTo` ("ABC" :: String) |
sjakobi
approved these changes
Aug 29, 2019
dhall/tests/Dhall/Test/Dhall.hs
Outdated
| , "2" `correspondsTo` (2 :: Natural) | ||
| , "+2" `correspondsTo` (2 :: Integer) | ||
| , "2.0" `correspondsTo` (2.0 :: Double) | ||
| -- , "2.0" `correspondsTo` (2.0 :: Scientific) |
There was a problem hiding this comment.
Can you add a comment regarding the missing instance?
dhall/tests/Dhall/Test/Dhall.hs
Outdated
| -- , "2.0" `correspondsTo` (2.0 :: Scientific) | ||
| , "\"ABC\"" `correspondsTo` ("ABC" :: Data.Text.Text) | ||
| , "\"ABC\"" `correspondsTo` ("ABC" :: Data.Text.Lazy.Text) | ||
| -- , "\"ABC\"" `correspondsTo` ("ABC" :: String) |
... so that we don't need to comment them out!
|
Actually, I realized that it was easier to just add the missing instances, so I'll do that |
|
Thanks for the quick fix! |
|
@jneira: You're welcome! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254
This also adds tests for conversions back and forth between Dhall and
Haskell values