Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1378] instance Interpret () #1388

Merged
merged 4 commits into from
Oct 6, 2019
Merged

Conversation

jiegillet
Copy link
Collaborator

As discussed in #1378. So much work :)

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! :)

@sjakobi
Copy link
Collaborator

sjakobi commented Oct 5, 2019

Ah, this seems to cause a build failure in the tasty testsuite:

C:\projects\dhall-haskell\dhall\tests\Dhall\Test\Dhall.hs:170:36: error:
    • Overlapping instances for Interpret ()
        arising from the 'deriving' clause of a data type declaration
      Matching instances:
        instance Interpret () -- Defined in ‘Dhall’
        instance Interpret () -- Defined at tests\Dhall\Test\Dhall.hs:175:1
    • When deriving the instance for (Interpret Records)
    |
170 |     deriving (Eq, Generic, Inject, Interpret, Show)
    |                                    ^^^^^^^^^

Can you remove the instance in the testsuite, @jiegillet?

@Gabriella439
Copy link
Collaborator

@jiegillet: It looks like the test suite had an orphan Interpret instance for () (because this feature hadn't been implemented!):

deriving instance Interpret ()

If you remove that then CI should passs

@mergify mergify bot merged commit cc3e50e into dhall-lang:master Oct 6, 2019
@jiegillet jiegillet deleted the jie-unit branch October 6, 2019 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants