Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-cache flag to dhall resolve. #1436

Merged
merged 2 commits into from
Oct 19, 2019

Conversation

StevenXL
Copy link
Contributor

@StevenXL StevenXL commented Oct 18, 2019

Part 1 of 2 for #1404 - I have to be frank here that I have not peeked under the covers of Dhall.Import.loadWith or its related functions, but I did the only sensible thing that could be done when adding the semanticCacheMode field to Resolve data constructor.

@sjakobi
Copy link
Collaborator

sjakobi commented Oct 18, 2019

Looks good! :) I have merged your first PR. Could you update the warning logic here?

@StevenXL
Copy link
Contributor Author

Looks good! :) I have merged your first PR. Could you update the warning logic here?

Will do!

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@mergify mergify bot merged commit 270addd into dhall-lang:master Oct 19, 2019
@StevenXL StevenXL deleted the extend--no-cache-flag branch October 19, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants