Resolve #1451: fix format --check given STDIN input.
#1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not really sure if this is the "best" approach so let me know if you know a way to simplify this. The issue was that `getExpressionAndHeader` was doing a second `IO.getContents` (thus reading STDIN twice).
mjgpy3
force-pushed
the
fix-format-check
branch
from
5633fe5
to
1904409
Compare
sjakobi
reviewed
Oct 23, 2019
dhall/src/Dhall/Util.hs
Outdated
| @@ -122,13 +125,21 @@ data Censor = NoCensor | Censor | |||
| -- | Path to input | |||
| data Input = StandardInput | InputFile FilePath | |||
|
|
|||
| -- | Path to input or raw input text, necessary since we can't read STDIN twice | |||
| data InputOrTextFromStdin = PathTo Input | StdinText Text | |||
There was a problem hiding this comment.
PathTo StandardInput seems like a bit of a strange combination to me. How about
Suggested change
| data InputOrTextFromStdin = PathTo Input | StdinText Text | |
| data InputOrTextFromStdin = Input_ Input | StdinText Text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure if this is the "best" approach so let me know if you
know a way to simplify this.
The issue was that
getExpressionAndHeaderwas doing a secondIO.getContents(thus reading STDIN twice).