dhall-lsp-server: Add option to only use ASCII when formatting and linting #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config so far consists of a single `asciiOnly` flag (whose intended behaviour is not yet implemented).
This commit adds functionality to the 'asciiOnly' flag, i.e. when turned on we don't output fancy non-ascii characters. Needs a recent version of the client to function -- the version on the marketplace does not relay configuration data to the server yet!
Gabriella439
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements server-side support for configuration via the LSP. Implements the so far only option 'vcsode-dhall-lsp-server.asciiOnly' (addresses #1529).
The current release version of the lsp client (i.e. vscode-dhall-lsp-server) does not yet pass configuration parameters on to the server; you need to build your own from this branch if you want to try this feature out right away.
