Small optimizations around Dhall.Map and Dhall.Set #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
Nov 23, 2019
While looking at some core I noticed that `null` for Dhall.Map used the default `foldr`-based definition. I fixed that and added a few more small optimizations.
sjakobi
force-pushed
the
sjakobi/small-optimizations
branch
from
b85e7c5
to
6afd280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at some core I noticed that
nullfor Dhall.Map usedthe default
foldr-based definition. I fixed that and added a fewmore small optimizations.