Fix escaping significant leading whitespace for multiline strings #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1590 This reuses the same logic for computing the longest shared whitespace prefix that the parser uses in order to ensure consistency of behavior between the two. Once we compute the longest shared whitespace prefix we escape *all* lines with that prefix. Only one such escape is technically necessary, but escaping all of them improves horizontal alignment of the result
sjakobi
approved these changes
Dec 7, 2019
... as suggested by @sjakobi Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1590
This reuses the same logic for computing the longest shared whitespace prefix
that the parser uses in order to ensure consistency of behavior between the
two. Once we compute the longest shared whitespace prefix we escape all
lines with that prefix. Only one such escape is technically necessary, but
escaping all of them improves horizontal alignment of the result