Fix dhall-json for new Prelude.JSON.Type
#1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhall-lang/dhall-lang#873 changed `Prelude.JSON.Type` which requires matching changes to `dhall-json` to support encoding/decoding Dhall expressions of that type. We still support the old type, too.
sjakobi
reviewed
Jan 15, 2020
| @@ -590,6 +590,77 @@ dhallFromJSON (Conversion {..}) expressionType = | |||
|
|
|||
| return result | |||
|
|
|||
| -- Arbitrary JSON ~> https://prelude.dhall-lang.org/JSON/Type (v13.0.0 <=) | |||
There was a problem hiding this comment.
Nice! I hadn't realized that json-to-dhall supports this at all!
There was a problem hiding this comment.
Yeah, this is documented here: https://github.com/Gabriel439/dhall-manual/blob/a0b4ceb9fead3ba151fc28f3b389573493b66f6b/manuscript/01-YamlToDhall.md
|
Regarding the Hydra failure, I suspect you need to enhance some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... based on an issue caught by @NicolasT
dhall-lang/dhall-lang#873 changed
Prelude.JSON.Typewhich requires matching changes todhall-jsonto support encoding/decoding Dhall expressions of that type. We
still support the old type, too.