Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source span for operator type errors #1824

Merged
merged 2 commits into from
May 30, 2020
Merged

Fix source span for operator type errors #1824

merged 2 commits into from
May 30, 2020

Conversation

Gabriella439
Copy link
Collaborator

Fixes #1819

@Gabriella439 Gabriella439 mentioned this pull request May 30, 2020
Closed
sjakobi
sjakobi approved these changes May 30, 2020
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

dhall/src/Dhall/Parser/Expression.hs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 5b10ba7 into master May 30, 2020
@mergify mergify bot deleted the gabriel/fix_type_error_2 branch May 30, 2020 19:32
Gabriella439 added a commit that referenced this pull request Jun 13, 2020
@Gabriella439
Fix double-nesting of Note constructors
f42d17d 
Fixes #1784

In #1824 I introduced a bug in computing source spans for `Note` constructors.
The (very indirect) consequence of this bug was that doubly-nested `Note`
constructors would show up in the syntax tree.

For example, the following command would generate *far* more `Note`
constructors than you would expect before this fix:

```bash
$ dhall haskell-syntax-tree --noted <<< 'A B'
```

Among other things, that broke the LSP server, which assumes that
`Note` constructors are only nested once.

I added a regression test to prevent this from recurring in the
future.
Gabriella439 added a commit that referenced this pull request Jun 13, 2020
@Gabriella439
Fix double-nesting of Note constructors
b29426d 
Fixes #1784

In #1824 I introduced a bug in computing source spans for `Note` constructors.
The (very indirect) consequence of this bug was that doubly-nested `Note`
constructors would show up in the syntax tree.

For example, the following command would generate *far* more `Note`
constructors than you would expect before this fix:

```bash
$ dhall haskell-syntax-tree --noted <<< 'A B'
```

Among other things, that broke the LSP server, which assumes that
`Note` constructors are only nested once.

I added a regression test to prevent this from recurring in the
future.
@Gabriella439 Gabriella439 mentioned this pull request Jun 13, 2020
Merged
mergify bot pushed a commit that referenced this pull request Jun 13, 2020
@Gabriella439
Fix double-nesting of Note constructors (#1849)
444e5db 
* Fix double-nesting of `Note` constructors

Fixes #1784

In #1824 I introduced a bug in computing source spans for `Note` constructors.
The (very indirect) consequence of this bug was that doubly-nested `Note`
constructors would show up in the syntax tree.

For example, the following command would generate *far* more `Note`
constructors than you would expect before this fix:

```bash
$ dhall haskell-syntax-tree --noted <<< 'A B'
```

Among other things, that broke the LSP server, which assumes that
`Note` constructors are only nested once.

I added a regression test to prevent this from recurring in the
future.

* Disable random string remote test

... since it's flaky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type mismatch error messages on binary operators
2 participants
@Gabriella439 @sjakobi