Fix double-nesting of Note constructors
#1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1784 In #1824 I introduced a bug in computing source spans for `Note` constructors. The (very indirect) consequence of this bug was that doubly-nested `Note` constructors would show up in the syntax tree. For example, the following command would generate *far* more `Note` constructors than you would expect before this fix: ```bash $ dhall haskell-syntax-tree --noted <<< 'A B' ``` Among other things, that broke the LSP server, which assumes that `Note` constructors are only nested once. I added a regression test to prevent this from recurring in the future.
|
The test failure was caused by |
sjakobi
approved these changes
Jun 13, 2020
|
I'm going to disable that test for now, since it keeps causing us issues |
... since it's flaky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1784
In #1824 I introduced a bug in computing source spans for
Noteconstructors.The (very indirect) consequence of this bug was that doubly-nested
Noteconstructors would show up in the syntax tree.
For example, the following command would generate far more
Noteconstructors than you would expect before this fix:
Among other things, that broke the LSP server, which assumes that
Noteconstructors are only nested once.I added a regression test to prevent this from recurring in the
future.