CBOR decoder performance #1857
Merged
CBOR decoder performance #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
Jun 14, 2020
sjakobi
reviewed
Jun 14, 2020
Comment on lines
+338
to
+339
| xs <- Data.Sequence.replicateA (len - 2) go | ||
| return (ListLit Nothing xs) |
There was a problem hiding this comment.
Did you test whether this is beneficial? I had tried this before, but it seemed to actually slow things down: #1804 (comment)
There was a problem hiding this comment.
Thanks for your response in #1804 (comment) @bgamari!
It's well possible that when I benchmarked this before, I was mislead by my noisy machine! I any case, the effect will not be huge.
sjakobi
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few minor issues in CBOR decoder performance. Specifically,
Data.Sequence.replicateAinstead ofData.Sequence.fromList . Data.List.replicate, avoiding an intermediate list