Correctly format duplicate fields #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
approved these changes
Sep 12, 2020
Comment on lines
+2
to
+4
| , foo.baz | ||
| = {- Comments within values are still preserved-} | ||
| 2 |
There was a problem hiding this comment.
This is unrelated to this PR, but makes me realize that maybe the = should rather be on the same line as the dotted fields:
Suggested change
| , foo.baz | |
| = {- Comments within values are still preserved-} | |
| 2 | |
| , foo.baz = | |
| {- Comments within values are still preserved-} | |
| 2 |
Having the = below the keys is IMHO mostly warranted when the keys are spread over several lines and especially when the last key has a trailing comment, e.g.
{ k
{- bla -}
= v
}
Thoughts? (We can move this discussion to a separate issue though.)
There was a problem hiding this comment.
@sjakobi: It should probably be a separate issue. I try to keep changes logically separate if possible
There was a problem hiding this comment.
I opened #2051 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2032