Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS compliance check #2121

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fix CORS compliance check #2121

merged 2 commits into from
Jan 8, 2021

Conversation

Gabriella439
Copy link
Collaborator

The CORS compliance check was previously not rejecting anything,
because the parent and child import were the same import, so it
would always succeed

@Gabriella439
Fix CORS compliance check
596712a 
The CORS compliance check was previously not rejecting anything,
because the parent and child import were the same import, so it
would always succeed
sjakobi
sjakobi approved these changes Jan 2, 2021
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something we ought to have a test for. No idea how to setup such a test though. Maybe record this on the dhall-lang issue tracker?!

@Gabriella439 Gabriella439 mentioned this pull request Jan 8, 2021
Closed
@Gabriella439
Copy link
Collaborator Author

@sjakobi: I created an issue to track that: dhall-lang/dhall-lang#1130

@mergify mergify bot merged commit 8938558 into master Jan 8, 2021
@mergify mergify bot deleted the gabriel/fix_cors branch January 8, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gabriella439 @sjakobi