Implement new fall-back behavior for ?
#2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and also track other standard changes, like parsing multiple shebang lines
Gabriella439
added a commit
that referenced
this pull request
May 31, 2021
I've temporarily disabled the import-related tests until #2203 is merged
sjakobi
reviewed
Jun 1, 2021
sjakobi
approved these changes
Jun 8, 2021
… and also simplify the file while we're at it, now that all of the relevant test files have a `.dhall` extension
This reverts commit 6961c73.
timbertson
added a commit
to timbertson/dhall-render
that referenced
this pull request
Aug 26, 2021
This supercedes the changes in f53b604 Thanks to dhall-lang/dhall-haskell#2203 (to be released in dhall 1.40.0), the `?` operator now only falls back on import not found, but not type errors etc. There's still some chance for accidental fallback, but that can now be worked around by using an intentional type error to prevent unwanted fallbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and also track other standard changes, like parsing
multiple shebang lines