Change ? to only fall back on absent imports
#1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1113 This changes the behavior of the `?` operator to only fall back to the second import if it cannot be retrieved (either from the cache or the specified location). In particular, it will not recover from type errors, parse errors, cyclic imports, or hash mismatches.
|
Matching change to the Haskell implementation: dhall-lang/dhall-haskell#2203 |
TristanCacqueray
approved these changes
May 31, 2021
sjakobi
reviewed
Jun 1, 2021
… as suggested by @TristanCacqueray
… as suggested by @sjakobi Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
…g/dhall-lang into gabriel/don't_always_fall_back
… as suggested by @sjakobi Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
…g/dhall-lang into gabriel/don't_always_fall_back
Nadrieril
approved these changes
Jun 1, 2021
TristanCacqueray
approved these changes
Jun 2, 2021
In particular, clarify what happens if `e₀` successfully resolves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113
This changes the behavior of the
?operator to only fall back tothe second import if it cannot be retrieved (either from the
cache or the specified location). In particular, it will not
recover from type errors, parse errors, cyclic imports, or hash
mismatches.