Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch grammar of Natural and Integer #381

Merged
merged 2 commits into from
May 12, 2018

Conversation

Gabriella439
Copy link
Collaborator

... as standardized in dhall-lang/dhall-lang#141

Now Naturals no longer require a leading + and non-negative Integers
require a leading +

... as standardized in dhall-lang/dhall-lang#141

Now `Natural`s no longer require a leading `+` and non-negative `Integer`s
require a leading `+`
Copy link
Collaborator

@joneshf joneshf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

It's pretty impressive how much of this diff is not source code changes.

The changes look good. But I think some things were missed in comments/docs. These are the ones I found:

I didn't really look through the tests too deeply. I figure the tests have less documentation and more code that will be executed; they ought to catch mismatches.

@Gabriella439
Copy link
Collaborator Author

Good catch! I will fix those and also see if I can add doctests to check those

... as caught by @joneshf

This also adds a `doctest` test suite to prevent regressions in those
examples
@Gabriella439 Gabriella439 merged commit 2e631db into master May 12, 2018
@Gabriella439 Gabriella439 deleted the gabriel/natural_integer_switch branch May 12, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants