Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBOR-encode only some special values as half-floats #822

Merged
merged 9 commits into from
Feb 23, 2019
Merged

CBOR-encode only some special values as half-floats #822

merged 9 commits into from
Feb 23, 2019

Conversation

f-f
Copy link
Member

@f-f f-f commented Feb 16, 2019

As standardized in dhall-lang/dhall-lang#376

basile-henry
basile-henry approved these changes Feb 17, 2019
View reviewed changes
Copy link
Collaborator

@basile-henry basile-henry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dhall/src/Dhall/Binary.hs Outdated Show resolved Hide resolved
dhall/src/Dhall/Binary.hs Outdated Show resolved Hide resolved
basile-henry and others added 2 commits February 17, 2019 20:00
@basile-henry @f-f
Update dhall/src/Dhall/Binary.hs
54e77f1 
Co-Authored-By: f-f <fabrizio.ferrai@gmail.com>
@basile-henry @f-f
Update dhall/src/Dhall/Binary.hs
0d8584c 
Co-Authored-By: f-f <fabrizio.ferrai@gmail.com>
@f-f
Copy link
Member Author

f-f commented Feb 17, 2019

Note: I'll also setup the "binary" tests in this PR once the change to the standard is merged

@Gabriella439 Gabriella439 merged commit 8527a65 into master Feb 23, 2019
@Gabriella439 Gabriella439 deleted the f-f/half-float-encoding branch February 23, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@basile-henry basile-henry basile-henry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f-f @Gabriella439 @basile-henry