Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-to-dhall initial implementation #884

Merged
merged 13 commits into from
Apr 14, 2019

Conversation

antislava
Copy link
Collaborator

@antislava antislava commented Apr 9, 2019

Description: json-to-dhall(s, j) -> d, where j is a valid JSON being converted, s is a Dhall type (schema), and d is the resulting Dhall value (term).

Background: json-to-dhall · Issue #878 · dhall-lang/dhall-haskell

Note: All the conversion logic is currently in Main.hs and will have to be factored out to dhall-json library in the future, to make it usable in other Haskell projects. This should be a separate next step as it will require some coordination with the dhall-to-json logic of the library, following initial practical tests and find-tuning of the json-to-dhall tool, and most likely after some efforts to standardize/formalize JSON <=> Dhall conversion rules (which may also result in the upstreaming of the core logic to dhall-lang).

@antislava antislava mentioned this pull request Apr 9, 2019
Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just a couple of small comments

I added you as a collaborator so that you can merge whenever you're ready

dhall-json/json-to-dhall/Main.hs Outdated Show resolved Hide resolved
dhall-json/json-to-dhall/Main.hs Outdated Show resolved Hide resolved
@albertov
Copy link

This is very useful, thanks! Currently using an adapted version while it is in Main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants