-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json-to-dhall initial implementation #884
Merged
antislava
merged 13 commits into
dhall-lang:master
from
antislava:antislava/json-to-dhall
Apr 14, 2019
Merged
json-to-dhall initial implementation #884
antislava
merged 13 commits into
dhall-lang:master
from
antislava:antislava/json-to-dhall
Apr 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Gabriella439
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Just a couple of small comments
I added you as a collaborator so that you can merge whenever you're ready
This is very useful, thanks! Currently using an adapted version while it is in Main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
json-to-dhall(s, j) -> d
, wherej
is a valid JSON being converted,s
is a Dhall type (schema), andd
is the resulting Dhall value (term).Background: json-to-dhall · Issue #878 · dhall-lang/dhall-haskell
Note: All the conversion logic is currently in
Main.hs
and will have to be factored out todhall-json
library in the future, to make it usable in other Haskell projects. This should be a separate next step as it will require some coordination with thedhall-to-json
logic of the library, following initial practical tests and find-tuning of thejson-to-dhall
tool, and most likely after some efforts to standardize/formalize JSON <=> Dhall conversion rules (which may also result in the upstreaming of the core logic to dhall-lang).