Use json-to-dhall to implement yaml-to-dhall #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
May 29, 2019
robbiemcmichael
force-pushed
the
yaml-to-dhall
branch
from
1e87820
to
6035879
Compare
robbiemcmichael
force-pushed
the
yaml-to-dhall
branch
from
6035879
to
fbd7370
Compare
|
@Gabriel439 Looks like I don't have the ability to merge as I don't have write access. Could you please merge this PR if you're happy with the changes? |
|
@robbiemcmichael: Yeah, no problem! Also, great job on documentation 🙂 Double-check your inbox and/or spam folder because I believe you should have an invite e-mail to become a collaborator, which would grant you write access for future contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was really happy to see @antislava implemented
json-to-dhallrecently in #884. This refactors that code into thedhall-jsonlibrary so that we can easily implementyaml-to-dhallas well.It could probably be cleaned up a bit more, happy to take suggestions of further refactoring as well.