Improve use of unions in tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a byte-for-byte duplicate of unionOfTypesA.dhall in the same directory
Now that we have empty union alternatives, we don't need to use empty records as singleton union alternative types in our tests. Our tests are also example code, and we should aim to keep them idiomatic as the language evolves.
We didn't have a unit test for type inference on merging an empty alternative.
Union literals are deprecated in favour of union constructors. Therefore, tests should prefer union constructors over union literals except in cases where union literals cannot be avoided. This is mainly in cases where union literals themselves are being tested. I also changed some filenames to make clear when union literals are under test.
Gabriella439
approved these changes
May 11, 2019
singpolyma
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details.