using toMap requires parentheses
#914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change clarifies (via the test suite) that custom headers using `toMap` have to be parenthesized. The Haskell implementation was permitting an unparenthesized `toMap`, which was not standards-compliant.
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 15, 2020
... as clarified in dhall-lang/dhall-lang#914
Nadrieril
approved these changes
Feb 15, 2020
sjakobi
approved these changes
Feb 15, 2020
mergify bot
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 17, 2020
* Match standard with respect to `using toMap` ... as clarified in dhall-lang/dhall-lang#914 * Fix `dhall-lang` reference to point to `master` Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change clarifies (via the test suite) that custom headers using
toMaphave to be parenthesized. The Haskell implementation waspermitting an unparenthesized
toMap, which was not standards-compliant.