Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative link recursion or remove support for it #23

Closed
dharple opened this issue Feb 3, 2021 · 0 comments
Closed

Fix relative link recursion or remove support for it #23

dharple opened this issue Feb 3, 2021 · 0 comments
Labels
bug
Projects
detox v2.0

Comments

@dharple
Copy link
Owner

dharple commented Feb 3, 2021

While testing detox I accidentally ran it across my entire projects directory (all of my dev projects) when I created a symlink in /tmp that pointed at ../.. and then ran detox in a test with -r --special.
@dharple dharple added this to To do in detox v2.0 via automation Feb 3, 2021
@dharple dharple added the bug label Feb 21, 2021
@dharple dharple moved this from To Do to In Progress in detox v2.0 Feb 21, 2021
@dharple dharple moved this from In Progress to Done in detox v2.0 Feb 21, 2021
dharple added a commit that referenced this issue Feb 21, 2021
@dharple
Safely confirm that bug #23 is still an issue
1723ad9
dharple added a commit that referenced this issue Feb 21, 2021
@dharple
Don't recurse into symlinks that point at directories. #23
05b5391
@dharple dharple mentioned this issue Feb 21, 2021
Closed
@dharple dharple closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
No open projects
detox v2.0
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dharple