Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on pip 20.1 #40

Closed
craigds opened this issue Apr 29, 2020 · 1 comment · Fixed by #41
Closed

Broken on pip 20.1 #40

craigds opened this issue Apr 29, 2020 · 1 comment · Fixed by #41

Comments

@craigds
Copy link

craigds commented Apr 29, 2020

With pip 20.1 (released today) and liccheck 0.4.2, we get this:

$ liccheck -l CAUTIOUS -s requirements/licenses.ini -r requirements.txt
gathering licenses...
Traceback (most recent call last):
  File "/Users/cdestigter/checkout/sno/venv/bin/liccheck", line 11, in <module>
    load_entry_point('liccheck==0.4.2', 'console_scripts', 'liccheck')()
  File "/Users/cdestigter/checkout/sno/venv/lib/python3.7/site-packages/liccheck/command_line.py", line 316, in main
    sys.exit(run(args))
  File "/Users/cdestigter/checkout/sno/venv/lib/python3.7/site-packages/liccheck/command_line.py", line 311, in run
    return process(args.requirement_txt_file, strategy, args.level)
  File "/Users/cdestigter/checkout/sno/venv/lib/python3.7/site-packages/liccheck/command_line.py", line 246, in process
    pkg_info = get_packages_info(requirement_file)
  File "/Users/cdestigter/checkout/sno/venv/lib/python3.7/site-packages/liccheck/command_line.py", line 127, in get_packages_info
    if req.markers:
AttributeError: 'ParsedRequirement' object has no attribute 'markers'
craigds added a commit to koordinates/kart that referenced this issue Apr 29, 2020
@ochedru
Copy link
Collaborator

ochedru commented Apr 29, 2020

Indeed pip has been heavily refactored in version 20.1 (check out e.g. pypa/pip@90e4eb3), and liccheck depends on its internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants