-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow regex matching #94
Conversation
Thank you for your PR! Can you please rebase it? I had to revert to ubuntu-20.04 in the github actions to make the build work. |
Done ! |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 84.05% 83.40% -0.65%
==========================================
Files 9 9
Lines 464 470 +6
Branches 90 93 +3
==========================================
+ Hits 390 392 +2
- Misses 62 65 +3
- Partials 12 13 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Well I should remove type hinting for compatibility with Python 2 |
Yup, and there is also an f-string. Maybe we'll drop support for Python 2 in the next major version. |
Ah yes my bad, I don't have Python 2 on my system so I cannot check it thoroughly |
The tests are ok. Could you please add an example of regex matching in the readme file, so users know how to use your feature? Thanks! |
Done ! |
See #93