Fixed bug with performing the http.get inside the loop of each build.

dhchow · Oct 30, 2011 · 8de63a6 · 8de63a6
1 parent 9303c1c
commit 8de63a6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/scripts/teamcity.coffee b/src/scripts/teamcity.coffee
@@ -20,7 +20,8 @@ module.exports = (robot) ->
           return
         # Sort by build number.
         builds = JSON.parse(body).build.sort((a, b)-> parseInt(b.number) - parseInt(a.number))
-        for build in builds
+
+        displayBuild = (msg, build) ->
           msg.http("http://#{hostname}#{build.href}")
             .headers(Authorization: "Basic #{new Buffer("#{username}:#{password}").toString("base64")}", Accept: "application/json")
             .get() (err, res, body) ->
@@ -39,4 +40,7 @@ module.exports = (robot) ->
               else if build.status is "SUCCESS"
                 msg.send "#{project.buildType.projectName} - #{build.number} is full of win"
               else if build.status is "FAILUED"
-                msg.send "#{project.buildType.projectName} - #{build.number} is #fail"
+                msg.send "#{project.buildType.projectName} - #{build.number} is #fail"
+
+        for build in builds
+          displayBuild(msg, build)