chore(lint): fix unicorn/explicit-length-check

dherault · Jan 2, 2023 · 0dbde70 · 0dbde70
1 parent e3601f2
commit 0dbde70
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -68,7 +68,6 @@ module.exports = {
     'unicorn/catch-error-name': 'off',
     'unicorn/consistent-destructuring': 'off',
     'unicorn/consistent-function-scoping': 'off',
-    'unicorn/explicit-length-check': 'off',
     'unicorn/filename-case': 'off',
     'unicorn/no-abusive-eslint-disable': 'off',
     'unicorn/no-array-callback-reference': 'off',

diff --git a/src/events/http/HttpServer.js b/src/events/http/HttpServer.js
@@ -519,7 +519,7 @@ export default class HttpServer {
         request.payload.length > 1
       ) {
         try {
-          if (!request.payload || request.payload.length < 1) {
+          if (!request.payload || request.payload.length === 0) {
             request.payload = '{}'
           }
 
@@ -748,7 +748,7 @@ export default class HttpServer {
         const { responseTemplates } = chosenResponse
 
         if (typeof responseTemplates === 'object') {
-          if (keys(responseTemplates).length) {
+          if (keys(responseTemplates).length > 0) {
             // BAD IMPLEMENTATION: first key in responseTemplates
             const responseTemplate = responseTemplates[responseContentType]
 
@@ -1137,7 +1137,7 @@ export default class HttpServer {
 
     const resourceRoutes = parseResources(this.#serverless.service.resources)
 
-    if (!resourceRoutes || !keys(resourceRoutes).length) {
+    if (!resourceRoutes || keys(resourceRoutes).length === 0) {
       return
     }
 

diff --git a/src/events/http/createJWTAuthScheme.js b/src/events/http/createJWTAuthScheme.js
@@ -67,7 +67,7 @@ export default function createAuthScheme(jwtOptions) {
         }
 
         let scopes = null
-        if (jwtOptions.scopes && jwtOptions.scopes.length) {
+        if (jwtOptions.scopes && jwtOptions.scopes.length > 0) {
           if (!scope) {
             log.notice(`JWT Token missing valid scope`)