Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing F2 while DOOMEdit is running has strange results. #300

Closed
TommyHanusa opened this issue Jul 19, 2020 · 3 comments
Closed

Pressing F2 while DOOMEdit is running has strange results. #300

TommyHanusa opened this issue Jul 19, 2020 · 3 comments

Comments

@TommyHanusa
Copy link

On Windows 10 64-bit if the "f2" key is pressed it produces strange results when DoomEdit is running.

Repro steps:

  1. Launch Dhewm3 1.5.1rc1 DOOMEdit with a shortcut using a shortcut targeted to "YOURPATH\dhewm3\dhewm3.exe" +set r_fullscreen 0 +set r_multiSamples 0 +editor

  2. Press the F2 key. There will be strange results
    DoomEditF2_2

Note:
This can alternatively be done by clicking a specific button.
DoomEditF2_1
@DanielGibson
Copy link
Member

Thanks for testing the editor - apparently you're the first one to do so after my minimal testing when I integrated it :-)

I'll look at them and plan to fix them before the "real" 1.5.1 release.

This particular bug looks like it's related to 5c1e1d7 which looked like this: d3-particle-edit-bug

DanielGibson added a commit that referenced this issue Jul 20, 2020
@DanielGibson
(Hopefully) fix Editors messing up game viewport for good, fix #300
31e2685 
I worked around the issue for the particle editor, but now it turned out
it can also somehow happen when switching from the Radiant to the Engine
(with F2), so I implemented the "proper" fix of restoring
glConfig.vidWidth/Height, that are overwritten in
RenderSystemLocal::BeginFrame(), in RenderSystemLocal::EndFrame().
@DanielGibson
Copy link
Member

DanielGibson commented Jul 20, 2020 •
edited
Loading

I think I have a fix for this, though I couldn't always (but sometimes) reproduce this issue - it didn't always happen when switching to the engine with F2.. but OTOH I had an even worse bug (before I also fixed that): The game was frozen when starting it from the editor. Menu and Console were working, but I couldn't move ingame and neither did anything else in the level move..

Anyway, can you test the following build: dhewm3_1.5.1_RC1-editorfixes_win32.zip ?

Thanks in advance, and thanks for the detailed reports! :)

@DanielGibson DanielGibson mentioned this issue Jul 20, 2020
Closed
@TommyHanusa
Copy link
Author

This issue no longer reproduces in dhewm3_1.5.1_RC1-editorfixes2_win32.zip

rorgoroth pushed a commit to rorgoroth/dhewm3 that referenced this issue Apr 8, 2023
@DanielGibson
(Hopefully) fix Editors messing up game viewport for good, fix dhewm#300
5960bd1 


I worked around the issue for the particle editor, but now it turned out
it can also somehow happen when switching from the Radiant to the Engine
(with F2), so I implemented the "proper" fix of restoring
glConfig.vidWidth/Height, that are overwritten in
RenderSystemLocal::BeginFrame(), in RenderSystemLocal::EndFrame().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielGibson @TommyHanusa