-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issue with old versions of OPC firmware #16
Comments
Hi Paul! I'll take a look at that. I made some changes when firmware v18 came out which includes a method for firmware version...Alphasense also changed the way they do firmware versioning from |
Probably not good use of your time to fix. Maybe just tell people to use another way to find the version. It functions OK as is because major version shows up as zero which does not break anything else. Most people will probably upgrade to >=18 anyway. |
Ahhh. What version of the library are you using? I thought I fixed that
David H Hagan |
Wait a sec...haha For some reason I thought this was an issue with the Python Library...I'll take a look at this in the next 48 hours or so. Curious...which device are you using this library with? A particle photon/electron? Or an Arduino? |
I downloaded it from github in the last few days. I do not see a version number in opcn2.cpp. |
Ahh okay. The version number is usually in the spark.json file. It should also be able to be downloaded straight from the library management tool within the Particle Build IDE. Let me know if it's not! |
BTW. With a small change (Serial1 instead of Serial) it also runs on Bluz. All good :-) |
Awesome! It looks like anytime I make an update to the library, the Particle IDE makes the library private again, which is pretty obnoxious. They told me it would be fixed when they release their new library management system soon. |
@paultanner I think I patched it last night with v0.3.3. Do you mind checking to see if it worked with your OPC? I don't have any with firmware < 18.2 |
thx @dhhagan. |
Awesome! I'll go ahead and close this then! |
I noticed that the version is not reported when the device sends back this string
You mention this in the code but not in the READ.ME; I patched it to address this. I'll do it properly when the project is further along.
BTW. Thx for doing this. Your code is a lot more readable than the device documentation ;-)
The text was updated successfully, but these errors were encountered: