Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable login app type #845

Merged
merged 9 commits into from
Apr 25, 2024
Merged

feat: enable login app type #845

merged 9 commits into from
Apr 25, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Apr 23, 2024

This PR merges in the changes that are on alpha v10.6.0-alpha3 release (https://github.com/dhis2/app-platform/releases/tag/v10.6.0-alpha.3) that make possible using app-platform for login app types.

tomzemp and others added 7 commits March 5, 2024 15:28
@tomzemp
feat: updates for login_app type [LIBS-405] (#831)
0cc2fbd
@dhis2-bot
chore(release): cut 10.6.0-alpha.1 [skip release]
dcdf8d8 
# [10.6.0-alpha.1](v10.5.0...v10.6.0-alpha.1) (2024-03-05)

### Features

* updates for login_app type [LIBS-405]  ([#831](#831)) ([0cc2fbd](0cc2fbd))
@tomzemp
feat: add redirect to safe login mode for login apps (#835)
ba26ada
@dhis2-bot
chore(release): cut 10.6.0-alpha.2 [skip release]
a2ba40d 
# [10.6.0-alpha.2](v10.6.0-alpha.1...v10.6.0-alpha.2) (2024-03-20)

### Features

* add redirect to safe login mode for login apps ([#835](#835)) ([ba26ada](ba26ada))
@kabaros
feat: enable publishing login_app apps
93093ca
@dhis2-bot
chore(release): cut 10.6.0-alpha.3 [skip release]
29fea13 
# [10.6.0-alpha.3](v10.6.0-alpha.2...v10.6.0-alpha.3) (2024-03-21)

### Features

* enable publishing login_app apps ([93093ca](93093ca))
@tomzemp
Merge branch 'master' into login-type-catchup
9477b8f
@tomzemp tomzemp changed the title Login type catchup feat: enable login app type Apr 23, 2024
@tomzemp
Copy link
Member Author

tomzemp commented Apr 25, 2024

Pushed some clean up (837624f)

Based on comments from @KaiVandivier :

  1. It might be nice to choose one of either login or loginApp as the boolean prop used through the adapter
  2. I didn’t really understand this comment in the ServerVersionProvider: “version is not currently available, minimum for login app” — is that like “we don’t need the whole system info for the login app, but we need the server version at the minimum to proceed”?
    P.S. since the login app type uses skipApiVersion on the app-runtime provider, is fetching the server version in a login app just to satisfy the type requirement for the config prop on the Provider or something (or the version parsing functions)?
  1. harmonized
  2. these are dated given that the changes were initially made before versioning was available and supported on login configuration

@tomzemp tomzemp merged commit 2586e38 into master Apr 25, 2024
6 checks passed
@tomzemp tomzemp deleted the login-type-catchup branch April 25, 2024 11:44
dhis2-bot added a commit that referenced this pull request Apr 25, 2024
@dhis2-bot
chore(release): cut 11.2.0 [skip release]
980750a 
# [11.2.0](v11.1.1...v11.2.0) (2024-04-25)

### Features

* enable login app type ([#845](#845)) ([2586e38](2586e38))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@martinakraus martinakraus mentioned this pull request Jun 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabaros kabaros kabaros approved these changes

@KaiVandivier KaiVandivier Awaiting requested review from KaiVandivier

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomzemp @dhis2-bot @kabaros