Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up for plugins [LIBS-620] #851

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jun 5, 2024

This does some clean up for issues noticed by @edoardo when testing plugins implementation:

CSS

  • removes some styling on one of the outer divs for plugins (e4b73d7). I have tested with auto resizing plugins, and the flex styling seems to not have an effect. The fitContent styling is not being applied anyway.
  • removes translucent from plugin Loading layer (997254f). We decided to do this before (fix: make loading placeholders transparent #795), but it might have got lost in merge/redoing the plugin loading logic.

Prop type checking

  • fixes some invalid prop types checking (6af1064)

@tomzemp tomzemp requested review from edoardo, KaiVandivier and a team June 5, 2024 11:54
@tomzemp tomzemp merged commit 13af3b5 into master Jun 6, 2024
6 checks passed
@tomzemp tomzemp deleted the LIBS-620/plugins-cleanup branch June 6, 2024 14:04
dhis2-bot added a commit that referenced this pull request Jun 6, 2024
## [11.4.1](v11.4.0...v11.4.1) (2024-06-06)

### Bug Fixes

* clean up for plugins [LIBS-620] ([#851](#851)) ([13af3b5](13af3b5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 11.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Jun 20, 2024
# [12.0.0-alpha.2](v12.0.0-alpha.1...v12.0.0-alpha.2) (2024-06-20)

### Bug Fixes

* clean up for plugins [LIBS-620] ([#851](#851)) ([13af3b5](13af3b5))
* do not encode username, password ([#852](#852)) ([2fb4272](2fb4272))
* don't start plugins for apps without a plugin entrypoint ([#850](#850)) ([a89d4cf](a89d4cf))

### Features

* parse pluginType from d2 config to add to manifest.webapp ([#849](#849)) ([c1dae23](c1dae23))
* start plugin and app separately [LIBS-391] [LIBS-392] ([#848](#848)) ([82003e7](82003e7))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 12.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants