fix: do not encode username, password [LIBS-625] #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVandivier
approved these changes
Jun 17, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jun 18, 2024
## [11.4.2](v11.4.1...v11.4.2) (2024-06-18) ### Bug Fixes * do not encode username, password ([#852](#852)) ([2fb4272](2fb4272))
|
🎉 This PR is included in version 11.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Jun 20, 2024
# [12.0.0-alpha.2](v12.0.0-alpha.1...v12.0.0-alpha.2) (2024-06-20) ### Bug Fixes * clean up for plugins [LIBS-620] ([#851](#851)) ([13af3b5](13af3b5)) * do not encode username, password ([#852](#852)) ([2fb4272](2fb4272)) * don't start plugins for apps without a plugin entrypoint ([#850](#850)) ([a89d4cf](a89d4cf)) ### Features * parse pluginType from d2 config to add to manifest.webapp ([#849](#849)) ([c1dae23](c1dae23)) * start plugin and app separately [LIBS-391] [LIBS-392] ([#848](#848)) ([82003e7](82003e7))
|
🎉 This PR is included in version 12.0.0-alpha.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the username and password were being encoded before being passed to api/login.
I had copied some of the code from the old login logic, but that is using
Content-Type:application/x-www-form-urlencoded, so requires encoding, whereas the post with json body, does not need that encoding 🤦♂️.Before
payload like
{"username": "admin", "password": "District1%23"}After
payload like
{"username": "admin", "password": "District1#"}