Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): remove cli-app-scripts peer dep #1377

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Apr 2, 2024

Part of LIBS-587; see this comment for reasoning

To test this out, I'm thinking we can:

  1. release this on alpha
  2. in the app platform repo, update the @dhis/app-runtime dependency to alpha
  3. then release an alpha of the app platform repo
  4. in the d2 CLI repo, update the dependency on @dhis2/cli-app-scripts to the alpha version
  5. release an alpha of the d2 CLI
  6. then test out installing that alpha version of the CLI with npm

@KaiVandivier KaiVandivier changed the base branch from master to alpha April 2, 2024 11:57
@kabaros kabaros changed the base branch from alpha to master April 2, 2024 13:15
@kabaros kabaros changed the base branch from master to alpha April 2, 2024 13:32
@kabaros kabaros merged commit 7764439 into alpha Apr 2, 2024
18 of 20 checks passed
@kabaros kabaros deleted the libs-587-fix-deps-for-infinite-loop branch April 2, 2024 14:16
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants