feat: add online status #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
approved these changes
Aug 13, 2021
dhis2-bot
added a commit
that referenced
this pull request
Aug 13, 2021
# [2.9.0](v2.8.0...v2.9.0) (2021-08-13) ### Features * add online status ([#953](#953)) ([9b45a81](9b45a81))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
amcgee
requested changes
Aug 16, 2021
| } | ||
| ``` | ||
|
|
||
| #### `CacheableSection` API |
There was a problem hiding this comment.
Oops, I meant to delete all but the online status 🤭
| ({ type }: Event) => setOnline(type === 'online'), | ||
| options?.debounceDelay || 1000 | ||
| ), | ||
| [] |
There was a problem hiding this comment.
This needs to have options in the dependency array
There was a problem hiding this comment.
Otherwise when updating the debounce delay based on a prop the callback will never get recreated (should also add a test for this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the
useOnlineStatushook from thefeat-add-offline-servicebranch so that it can be available independently of the other PWA features, which will support progress on LIBS-48: Display connection status in global interface