-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: avoid visualization plugin double render (#1665)
* refactor: remove unused action * fix: pass the same userSettings object to VisualizationPlugin props This avoids a double render issue which causes the Highcharts config generation to run twice. * refactor: list all used props in the deconstructor * fix: init id as null to avoid rerender when not passed This happened in dashboards where id is not passed to ChartPlugin because the re-render on resize with no animation is only needed in DV. Co-authored-by: Martin Ohlson <martin@moid.se>
- Loading branch information
1 parent
43c4842
commit 88bd9db
Showing
5 changed files
with
23 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters