fix: avoid visualization plugin double render #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a double render issue which causes the Highcharts config generation to run twice.
martinkrulltott
approved these changes
Mar 18, 2021
This avoids a double render issue which causes the Highcharts config generation to run twice.
This happened in dashboards where id is not passed to ChartPlugin because the re-render on resize with no animation is only needed in DV.
martinkrulltott
approved these changes
Mar 19, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 19, 2021
## [35.20.20](v35.20.19...v35.20.20) (2021-03-19) ### Bug Fixes * avoid visualization plugin double render ([#1665](#1665)) ([c6c348c](c6c348c))
|
🎉 This PR is included in version 35.20.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janhenrikoverland
pushed a commit
that referenced
this pull request
Mar 31, 2021
* refactor: remove unused action * fix: pass the same userSettings object to VisualizationPlugin props This avoids a double render issue which causes the Highcharts config generation to run twice. * refactor: list all used props in the deconstructor * fix: init id as null to avoid rerender when not passed This happened in dashboards where id is not passed to ChartPlugin because the re-render on resize with no animation is only needed in DV. Co-authored-by: Martin Ohlson <martin@moid.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
Description
The cause for it was the
userSettingsprop passed toVisualizationPlugin. The prop was a new object every time, causing unwanted re-render.The fix prevents the Highcharts config generation to run multiple times.