Use deep equality check for plugin props (#254)

dhis2 · Apr 29, 2019 · 93f71ab · 93f71ab
1 parent 62241f8
commit 93f71ab
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/plugin/src/ChartPlugin.js b/packages/plugin/src/ChartPlugin.js
@@ -1,6 +1,6 @@
 import React, { Component, Fragment } from 'react';
 import PropTypes from 'prop-types';
-
+import isEqual from 'lodash-es/isEqual';
 import { createChart } from 'd2-charts-api';
 
 import { apiFetchVisualization } from './api/visualization';
@@ -32,12 +32,12 @@ class ChartPlugin extends Component {
     }
 
     componentDidUpdate(prevProps) {
-        if (this.props.config !== prevProps.config) {
+        if (!isEqual(this.props.config, prevProps.config)) {
             this.renderChart();
             return;
         }
 
-        if (this.props.filters !== prevProps.filters) {
+        if (!isEqual(this.props.filters, prevProps.filters)) {
             this.renderChart();
             return;
         }