fix: Use deep equality check for plugin props on componentDidUpdate to avoid unnecessary updates #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Apr 15, 2019
jenniferarnesen
approved these changes
Apr 24, 2019
|
Going to merge this one as a temp fix until we fix store design in dashboards app. |
jenniferarnesen
pushed a commit
that referenced
this pull request
Apr 29, 2019
jenniferarnesen
added a commit
that referenced
this pull request
Apr 29, 2019
This reverts commit 93f71ab.
|
🎉 This PR is included in version 33.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 8, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-6597.
Problem:
Chart items re-render in dashboards app even if props stay the same (triggers by editing text item).
Proposal:
Use
lodash/isEqualfunction to check equality of props (config & filter) to determine if component should re-render the chart.