fix: make annotations consistent in inheritence hierarchy

dhis2 · Jun 19, 2024 · de71ae2 · de71ae2
1 parent 7fad9b6
commit de71ae2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/dhis-2/dhis-api/src/main/java/org/hisp/dhis/scheduling/NoopJobProgress.java b/dhis-2/dhis-api/src/main/java/org/hisp/dhis/scheduling/NoopJobProgress.java
@@ -27,6 +27,7 @@
  */
 package org.hisp.dhis.scheduling;
 
+import javax.annotation.CheckForNull;
 import javax.annotation.Nonnull;
 
 /**
@@ -54,7 +55,7 @@ public void completedProcess(String summary, Object... args) {
   }
 
   @Override
-  public void failedProcess(@Nonnull String error, Object... args) {
+  public void failedProcess(@CheckForNull String error, Object... args) {
     // as the name said we do nothing
   }
 

diff --git a/...ervices/dhis-service-core/src/main/java/org/hisp/dhis/scheduling/NotifierJobProgress.java b/...ervices/dhis-service-core/src/main/java/org/hisp/dhis/scheduling/NotifierJobProgress.java
@@ -32,6 +32,7 @@
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import java.util.concurrent.atomic.AtomicBoolean;
+import javax.annotation.CheckForNull;
 import javax.annotation.Nonnull;
 import lombok.RequiredArgsConstructor;
 import org.hisp.dhis.system.notification.NotificationDataType;
@@ -80,7 +81,7 @@ public void completedProcess(String summary, Object... args) {
   }
 
   @Override
-  public void failedProcess(@Nonnull String error, Object... args) {
+  public void failedProcess(@CheckForNull String error, Object... args) {
     notifier.notify(jobId, NotificationLevel.ERROR, format(error, args), true);
   }