feat: adds configuration for primary leader node [DHIS2-16878] #17685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jimgrace
approved these changes
Jun 3, 2024
Comment on lines
+79
to
+80
| * When true, the node will unconditionally set its node ID during leader election causing it to | ||
| * win the election as long as it is alive. |
There was a problem hiding this comment.
I know this isn't (yet) end user documentation but I would suggest using the word "cluster" somewhere just so that people not concerned with clusters will skip over it faster.
vietnguyen
approved these changes
Jun 3, 2024
david-mackessy
approved these changes
Jun 4, 2024
|
@jimgrace Any news on the testing of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new configuration
node.primary_leaderthat when set to true/on the node will unconditionally set itself as the leader (as opposed to only setting its ID when no other value is present). This means (eventually) the node should always take over the leader role in a cluster as all other nodes will only set their ID in case no ID is set. This way other nodes only take over the leader role if the primary leader is in fact not able to renew (maintain) its leader role by setting its ID.